Render closed-interval-ranges for human legibility. #3441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like this. How about we just render it in the front-end as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, a satoshi range of [10; 12], which contains the elements {10, 11, 12}, would be rendered as 10-13. It's convenient for calculating its value, but highly misleading because it suggests that 13 is part of the interval, which it isn't.
The issue stems from the asymmetry of interval openness: the beginning of the interval is closed, and the ending is open.
To facilitate human legibility and convenience, the ends of intervals are now rendered as closed, too.
This PR might be controversial, so feel free to close.