-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add --no-wait flag to not wait for etching to mature #3526
base: master
Are you sure you want to change the base?
Conversation
@rot13maxi C-c? |
control-c |
) -> Result<batch::Output> { | ||
eprintln!("Waiting for rune commitment {} to mature…", commit.txid()); | ||
|
||
self.save_etching(rune, &commit, &reveal, output.clone())?; | ||
|
||
loop { | ||
if SHUTTING_DOWN.load(atomic::Ordering::Relaxed) { | ||
if SHUTTING_DOWN.load(atomic::Ordering::Relaxed) || no_wait { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not instead have a separate message for no_wait
instead of combining it with suspending batch....
message, else branch saying "commitment submiited, reveal is pending" something along that line.
f87a1dc
to
a635265
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this needs to be in ShareArgs
, since ord wallet inscribe
never needs to wait.
This is a good feature, any update on this? |
if you're going to C-c anyway, you can instead pass the
--no-wait
flag when you do an etching. Makes it easier to wrap this in a script, if you're into such degeneracy.not in love with the way this gets passed through, so marking it a draft for now.