Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle error properly in sendEmail function #5374

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Harmedino
Copy link

@Harmedino Harmedino commented Mar 19, 2024

Description

This pull request fixes an issue in the sendEmail function where errors were not being handled properly. Previously, the function would return errors instead of throwing them, leading to unexpected behavior in error handling. This change modifies the error handling mechanism to throw errors instead of returning them directly, ensuring consistent and expected behavior throughout the application.

The motivation behind this change is to improve the robustness and reliability of the email sending functionality within the application. By throwing errors, the application can more effectively handle and respond to email sending failures, leading to a better user experience overall.

This fix addresses the following issue: [link to the related issue, if applicable]

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have read and understand the CONTRIBUTING.md document in this repository.
  • I have added tests that prove my fix is effective or that my feature works
  • Existing test suite passes locally with my changes
  • I have made corresponding changes to the documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant