Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the window UI to look a bit more like Open Quickly #14

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Update the window UI to look a bit more like Open Quickly #14

wants to merge 7 commits into from

Conversation

tonyarnold
Copy link

🚨 Please don't merge yet 🚨

As per the discussion in #9, this is a quick refresh of the UI.

Screen shot of UI changes

This PR is a WIP, so feedback is appreciated. It's also missing some spacing, separators, icons and font treatments.
@pdcgomes
Copy link
Owner

It's looking good! I'd definitely add the item separator though.

Also, I've also been thinking that it could look interesting to toy around a bit with NSVisualEffectView, I know it wouldn't look exactly like Open Quickly but having a subtle blurred modern look could look pretty interesting. What do you think?
@tonyarnold
Copy link
Author

Thanks — yes, it definitely needs the separator, and something isn't sitting right with the line heights of the text.

There's an NSVisualEffectView backing the entire view already:

screen shot 2015-03-23 at 20 25 55
@pdcgomes
Copy link
Owner

Looking awesome! :)
@tonyarnold
Copy link
Author

Latest changes:

screen shot 2015-03-23 at 22 03 01

screen shot 2015-03-23 at 22 04 17

It could use some actual design love, but this feels good in use 😄
@pdcgomes
Copy link
Owner

Loving it!
Two things:

  1. Was thinking that it could be cool to surround the hint text with some kind of mask (a bit like markdown backticks to make it a bit more obvious that it's a shortcut/macro)

  2. Perhaps we should also consider larger titles/summaries and should just support variable height cells to accommodate a couple of lines of text each -- size consistency is good but pointless if people can't actually read what's in there :) What do you think?
@pdcgomes
Copy link
Owner

I'm getting the feature set for a 0.3 release ready, got a couple of things I want to work on but am aiming for later this week.

How's the UI work going?
@tonyarnold
Copy link
Author

Haven't had much time tonight, but the dynamic heights are already in there (just need to disable the single line mode on the text field in the XIB). I agree with your suggestion about some kind of outline around the key/snippet trigger text.

Hopefully I'll have some time tonight to finish that up.
@tonyarnold
Merge branch 'master' into feature/open-quickly-ui
b0e8129
@tonyarnold
Merge branch 'master' into feature/open-quickly-ui
c4ed137 
Conflicts:
	PGXcodeActionBrowser/Controllers/XCActionBarWindowController.m
	PGXcodeActionBrowser/Model/XCCodeSnippetProvider.m
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@tonyarnold @pdcgomes