Make maxJointNumber configurable

pissang · Jan 21, 2019 · e10343c · e10343c
1 parent 5eadc8d
commit e10343c
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/src/Renderer.js b/src/Renderer.js
@@ -179,6 +179,12 @@ var Renderer = Base.extend(function () {
          */
         viewport: {},
 
+        /**
+         * Max joint number
+         * @type {number}
+         */
+        maxJointNumber: 20,
+
         // Set by FrameBuffer#bind
         __currentFrameBuffer: null,
 
@@ -805,7 +811,7 @@ var Renderer = Base.extend(function () {
     },
 
     getMaxJointNumber: function () {
-        return this._glinfo.getMaxJointNumber();
+        return this.maxJointNumber;
     },
 
     _updateSkeleton: function (object, program, slot) {
@@ -815,7 +821,7 @@ var Renderer = Base.extend(function () {
         if (skeleton) {
             // TODO Update before culling.
             skeleton.update();
-            if (object.joints.length > this._glinfo.getMaxJointNumber()) {
+            if (object.joints.length > this.getMaxJointNumber()) {
                 var skinMatricesTexture = skeleton.getSubSkinMatricesTexture(object.__uid__, object.joints);
                 program.useTextureSlot(this, skinMatricesTexture, slot);
                 program.setUniform(_gl, '1i', 'skinMatricesTexture', slot);

diff --git a/src/core/GLInfo.js b/src/core/GLInfo.js
@@ -47,10 +47,6 @@ function GLInfo(_gl) {
         return parameters[name];
     };
 
-    this.getMaxJointNumber = function () {
-        return 15;
-    };
-
     function createExtension(name) {
         if (_gl.getExtension) {
             var ext = _gl.getExtension(name);