Dashboard: Fix countries/regions/cities tooltips #4580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously these tooltips said `Add filter: Country is undefined` because new labels were yet to be in `query`.
apata
approved these changes
Sep 16, 2024
There was a problem hiding this comment.
On testing, besides unit tests for adding and subtracting all kinds of filters, for this particular case I'd probably go one level up and render the ListReport with react test library, then expect the links to be present with the appropriate title. See query-dates.test.tsx for an example how to use react testing library for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously these tooltips said
Add filter: Country is undefinedbecause new labels were yet to be inquery.cc @apata - curious on your thoughts on if or how best test this
Basecamp: https://3.basecamp.com/5308029/buckets/36789884/card_tables/cards/7816925449