Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[BugFix] Fix tensordict private imports" #2276

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Jul 8, 2024

Reverts #2275

Copy link

pytorch-bot bot commented Jul 8, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2276

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Pending, 17 Unrelated Failures

As of commit c35be92 with merge base 95b6a16 (image):

NEW FAILURE - The following job has failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 8, 2024
@vmoens vmoens merged commit a151923 into main Jul 8, 2024
Copy link

github-actions bot commented Jul 8, 2024

Result of GPU Benchmark Tests

Expand to view detailed results
Name Max Mean Ops
test_single 0.1034s 0.1030s 9.7085 Ops/s
test_sync 94.7592ms 90.4973ms 11.0501 Ops/s
test_async 0.1701s 85.5883ms 11.6838 Ops/s
test_single_pixels 0.1139s 0.1133s 8.8286 Ops/s
test_sync_pixels 70.3138ms 69.4754ms 14.3936 Ops/s
test_async_pixels 0.1227s 57.2320ms 17.4727 Ops/s
test_simple 0.8159s 0.7475s 1.3378 Ops/s
test_transformed 1.0436s 0.9768s 1.0238 Ops/s
test_serial 2.2381s 2.1763s 0.4595 Ops/s
test_parallel 1.9036s 1.8433s 0.5425 Ops/s
test_step_mdp_speed[True-True-True-True-True] 91.1820μs 33.7653μs 29.6162 KOps/s
test_step_mdp_speed[True-True-True-True-False] 0.1240ms 19.3645μs 51.6408 KOps/s
test_step_mdp_speed[True-True-True-False-True] 39.6310μs 18.7874μs 53.2273 KOps/s
test_step_mdp_speed[True-True-True-False-False] 27.5910μs 11.0524μs 90.4781 KOps/s
test_step_mdp_speed[True-True-False-True-True] 0.2098ms 35.5101μs 28.1610 KOps/s
test_step_mdp_speed[True-True-False-True-False] 45.2020μs 20.9107μs 47.8225 KOps/s
test_step_mdp_speed[True-True-False-False-True] 0.2143ms 20.9445μs 47.7451 KOps/s
test_step_mdp_speed[True-True-False-False-False] 31.0800μs 13.0830μs 76.4350 KOps/s
test_step_mdp_speed[True-False-True-True-True] 74.1810μs 37.2557μs 26.8415 KOps/s
test_step_mdp_speed[True-False-True-True-False] 0.1928ms 23.0821μs 43.3236 KOps/s
test_step_mdp_speed[True-False-True-False-True] 0.2018ms 20.7171μs 48.2692 KOps/s
test_step_mdp_speed[True-False-True-False-False] 30.3810μs 12.9291μs 77.3451 KOps/s
test_step_mdp_speed[True-False-False-True-True] 0.2006ms 38.9138μs 25.6978 KOps/s
test_step_mdp_speed[True-False-False-True-False] 46.9810μs 24.8287μs 40.2760 KOps/s
test_step_mdp_speed[True-False-False-False-True] 0.2046ms 22.4421μs 44.5591 KOps/s
test_step_mdp_speed[True-False-False-False-False] 0.1997ms 14.5839μs 68.5686 KOps/s
test_step_mdp_speed[False-True-True-True-True] 69.6020μs 37.3211μs 26.7945 KOps/s
test_step_mdp_speed[False-True-True-True-False] 46.7810μs 23.1621μs 43.1741 KOps/s
test_step_mdp_speed[False-True-True-False-True] 42.0310μs 24.5678μs 40.7038 KOps/s
test_step_mdp_speed[False-True-True-False-False] 0.2041ms 14.5814μs 68.5806 KOps/s
test_step_mdp_speed[False-True-False-True-True] 65.9120μs 38.9231μs 25.6917 KOps/s
test_step_mdp_speed[False-True-False-True-False] 85.5620μs 24.9861μs 40.0223 KOps/s
test_step_mdp_speed[False-True-False-False-True] 49.9010μs 26.0822μs 38.3403 KOps/s
test_step_mdp_speed[False-True-False-False-False] 36.9510μs 16.3505μs 61.1601 KOps/s
test_step_mdp_speed[False-False-True-True-True] 0.1666ms 41.4831μs 24.1062 KOps/s
test_step_mdp_speed[False-False-True-True-False] 49.9810μs 26.9219μs 37.1445 KOps/s
test_step_mdp_speed[False-False-True-False-True] 51.6610μs 25.6755μs 38.9476 KOps/s
test_step_mdp_speed[False-False-True-False-False] 35.4210μs 16.3764μs 61.0636 KOps/s
test_step_mdp_speed[False-False-False-True-True] 64.5810μs 42.8421μs 23.3415 KOps/s
test_step_mdp_speed[False-False-False-True-False] 54.9120μs 28.5185μs 35.0650 KOps/s
test_step_mdp_speed[False-False-False-False-True] 49.9520μs 27.3812μs 36.5215 KOps/s
test_step_mdp_speed[False-False-False-False-False] 40.7910μs 18.0892μs 55.2817 KOps/s
test_values[generalized_advantage_estimate-True-True] 24.7723ms 24.2486ms 41.2395 Ops/s
test_values[vec_generalized_advantage_estimate-True-True] 91.0799ms 2.7283ms 366.5278 Ops/s
test_values[td0_return_estimate-False-False] 89.7820μs 65.1659μs 15.3454 KOps/s
test_values[td1_return_estimate-False-False] 56.4335ms 54.6680ms 18.2922 Ops/s
test_values[vec_td1_return_estimate-False-False] 1.4659ms 1.0886ms 918.5989 Ops/s
test_values[td_lambda_return_estimate-True-False] 87.5173ms 86.9401ms 11.5022 Ops/s
test_values[vec_td_lambda_return_estimate-True-False] 1.2525ms 1.0855ms 921.2564 Ops/s
test_gae_speed[generalized_advantage_estimate-False-1-512] 26.2913ms 25.3815ms 39.3988 Ops/s
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 0.9716ms 0.7270ms 1.3755 KOps/s
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.8334ms 0.6703ms 1.4919 KOps/s
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 1.6129ms 1.4685ms 680.9595 Ops/s
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 1.0039ms 0.6848ms 1.4604 KOps/s
test_dqn_speed 1.9096ms 1.4556ms 686.9788 Ops/s
test_ddpg_speed 3.2660ms 2.9554ms 338.3678 Ops/s
test_sac_speed 9.1570ms 8.4799ms 117.9261 Ops/s
test_redq_speed 13.6786ms 11.0371ms 90.6031 Ops/s
test_redq_deprec_speed 0.1139s 13.4164ms 74.5358 Ops/s
test_td3_speed 9.5073ms 8.4552ms 118.2709 Ops/s
test_cql_speed 26.8049ms 26.2127ms 38.1494 Ops/s
test_a2c_speed 6.0696ms 5.8339ms 171.4118 Ops/s
test_ppo_speed 6.3472ms 6.1367ms 162.9553 Ops/s
test_reinforce_speed 5.5002ms 4.8315ms 206.9759 Ops/s
test_iql_speed 20.8614ms 20.2032ms 49.4972 Ops/s
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 4.8572ms 4.6646ms 214.3805 Ops/s
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.2935ms 0.5546ms 1.8031 KOps/s
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7128ms 0.5309ms 1.8837 KOps/s
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 4.9870ms 4.6466ms 215.2093 Ops/s
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 1.2071ms 0.5460ms 1.8313 KOps/s
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.7224ms 0.5241ms 1.9080 KOps/s
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 2.5403ms 2.0423ms 489.6328 Ops/s
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 2.1435ms 1.9301ms 518.1198 Ops/s
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 5.0739ms 4.7660ms 209.8189 Ops/s
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.9084ms 0.6959ms 1.4371 KOps/s
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 5.7967ms 0.6760ms 1.4794 KOps/s
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 4.9106ms 4.6788ms 213.7307 Ops/s
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.7312ms 0.5520ms 1.8117 KOps/s
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 4.3311ms 0.5352ms 1.8686 KOps/s
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 5.1130ms 4.6636ms 214.4266 Ops/s
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 1.3595ms 0.5533ms 1.8074 KOps/s
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.6922ms 0.5286ms 1.8917 KOps/s
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 5.0897ms 4.8072ms 208.0227 Ops/s
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.9888ms 0.7081ms 1.4122 KOps/s
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 4.5780ms 0.6891ms 1.4511 KOps/s
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1346s 7.5298ms 132.8061 Ops/s
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 17.9836ms 15.4343ms 64.7909 Ops/s
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 2.2790ms 1.1607ms 861.5546 Ops/s
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1331s 10.0726ms 99.2794 Ops/s
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 17.8782ms 15.3881ms 64.9853 Ops/s
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 2.2398ms 1.1568ms 864.4601 Ops/s
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1357s 7.7081ms 129.7329 Ops/s
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 18.0910ms 15.7144ms 63.6358 Ops/s
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 2.4967ms 1.3342ms 749.5130 Ops/s
@vmoens vmoens deleted the revert-2275-fix-td-import branch August 7, 2024 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
2 participants