[LTC] Adopt more LazyGraphExecutor virtual interfaces #4314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanwaketan
force-pushed
the
alanwaketan/lazy_graph_4
branch
from
6e229d9
to
825f929
Compare
JackCaoG
reviewed
Dec 12, 2022
| coll->unlocker.size() > 0) { | ||
| return; | ||
| } | ||
| torch::lazy::LazyGraphExecutor::TensorCollectionBarrier(coll); |
There was a problem hiding this comment.
hmm so the reason we need to overwrite this function is for future SPMD use case?
There was a problem hiding this comment.
Yea, or I can add the todo to the upstream. 😂
JackCaoG
reviewed
Dec 12, 2022
| @@ -956,8 +924,7 @@ XLAGraphExecutor::PostOrderData XLAGraphExecutor::RunPostOrder( | |||
| } | |||
|
|
|||
| XLAGraphExecutor::ComputationCache::TypePtr | |||
| XLAGraphExecutor::LookupCachedCompile(const std::vector<XLATensorPtr>& tensors, | |||
There was a problem hiding this comment.
haha, I guess at some point we dropped the use of tensors without noticing it.
JackCaoG
approved these changes
Dec 12, 2022
|
Thanks Jack for approving. |
alanwaketan
force-pushed
the
alanwaketan/lazy_graph_4
branch
from
825f929
to
7d2301e
Compare
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Dec 13, 2022
Summary: This patch makes the following interfaces virtual for XLA to adopt: 1. LazyGraphExecutor::Async. 2. TensorCollectionBarrier 3. SyncLiveTensorsGraph It's related to pytorch/xla#4314. Test Plan: CI. Pull Request resolved: #90650 Approved by: https://github.com/wconstab
This reverts commit 7d2301e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This patch tries to adopt even more LazyGraphExecutor virtual interfaces:
And comments on methods that we don't adopt.
This depends on pytorch/pytorch#90650.
Test Plan:
CI.