[core][logging] Remove actor/task prefix from the logs shown on the driver process #47703
Conversation
| @property | ||
| def get_job_logging_config(self): | ||
| """Get the job's logging config for this worker""" | ||
| if not hasattr(self, "core_worker"): |
There was a problem hiding this comment.
In a test case like test_namespace_validation, ray.init() throws an exception (code) before initializing the core_worker. As a result, when the test calls ray.shutdown, which also calls get_job_logging_config, the core_worker doesn't exist.
Signed-off-by: kaihsun <kaihsun@anyscale.com>
python/ray/_private/worker.py
Outdated
| if not hasattr(self, "core_worker"): | ||
| return None | ||
| job_config = self.core_worker.get_job_config() | ||
| if job_config.serialized_py_logging_config == b"": |
There was a problem hiding this comment.
| if job_config.serialized_py_logging_config == b"": | |
| if not job_config.serialized_py_logging_config: |
This handles both None and empty string cases
There was a problem hiding this comment.
what is "empty string" case?
There was a problem hiding this comment.
This check has already handled the case that when LoggingConfig is None.
There was a problem hiding this comment.
I mean both serialized_py_logging_config being None or b""
There was a problem hiding this comment.
when will serialized_py_logging_config be None?
There was a problem hiding this comment.
I don't think it will now. It's just that not can handle both so more robust.
…river process (ray-project#47703) Signed-off-by: kaihsun <kaihsun@anyscale.com> Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
Why are these changes needed?
With this PR
Without this PR
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.