Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add manifestPeriodCount to player stats #6788

Closed
tykus160 opened this issue Jun 11, 2024 · 2 comments · Fixed by #6798 or #6724
Closed

Add manifestPeriodCount to player stats #6788

tykus160 opened this issue Jun 11, 2024 · 2 comments · Fixed by #6798 or #6724
Assignees
Labels
priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Milestone

Comments

@tykus160
Copy link
Member

Have you read the FAQ and checked for duplicate open issues?
Yes.

Is your feature request related to a problem? Please describe.

For the sake of telemetry, we are trying to monitor how many periods are in our streams. It often help during investigation of production issues.

Describe the solution you'd like

Add manifestPeriodCount to shaka.extern.Stats. For DASH, it should represent number of periods. For other manifests types, it should be probably set explicitly to 1.
When src= mode is used, it should be set to NaN as we are not able to determine it.

Describe alternatives you've considered

Register manifest preprocessor to count it on application side.

Additional context

Are you planning send a PR to add it?
Yes if there's an agreement.

@tykus160 tykus160 added the type: enhancement New feature or request label Jun 11, 2024
@avelad
Copy link
Member

avelad commented Jun 11, 2024

@theodab Can you give your opinion here?

@shaka-bot shaka-bot added this to the Backlog milestone Jun 11, 2024
@theodab
Copy link
Contributor

theodab commented Jun 11, 2024

This one also sounds reasonable to me.

@avelad avelad added the priority: P3 Useful but not urgent label Jun 11, 2024
@avelad avelad modified the milestones: Backlog, v4.10 Jun 11, 2024
avelad pushed a commit that referenced this issue Jun 12, 2024
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Aug 11, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Aug 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
4 participants