fix(Cast): Don't pause local video until the cast connection is established #6359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
added
type: enhancement
|
Incremental code coverage: 80.00% |
joeyparrish
requested changes
Mar 26, 2024
|
The way this fixed the issue was not at all obvious to me from the diff. This needed an explanation in the PR description to be understood. I'll add one, then approve & merge. |
joeyparrish
approved these changes
Mar 26, 2024
joeyparrish
changed the title
avelad
added a commit
that referenced
this pull request
Apr 8, 2024
…lished (#6359) CastProxy's getInitState_() pauses the local video as part of a transfer of state to the receiver. Calling getInitState_() (via CastSender's onInitStateRequired_()) should be deferred until we establish a connection. This keeps the local video from pausing during a connection attempt. Closes #6293
avelad
added a commit
that referenced
this pull request
Apr 8, 2024
…lished (#6359) CastProxy's getInitState_() pauses the local video as part of a transfer of state to the receiver. Calling getInitState_() (via CastSender's onInitStateRequired_()) should be deferred until we establish a connection. This keeps the local video from pausing during a connection attempt. Closes #6293
joeyparrish
pushed a commit
that referenced
this pull request
May 7, 2024
…lished (#6359) CastProxy's getInitState_() pauses the local video as part of a transfer of state to the receiver. Calling getInitState_() (via CastSender's onInitStateRequired_()) should be deferred until we establish a connection. This keeps the local video from pausing during a connection attempt. Closes #6293
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CastProxy's getInitState_() pauses the local video as part of a transfer of state to the receiver. Calling getInitState_() (via CastSender's onInitStateRequired_()) should be deferred until we establish a connection. This keeps the local video from pausing during a connection attempt.
Closes #6293