Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(UI): Remove spinner and client side ad container elements when calling destroy #7320

Merged
merged 1 commit into from
Sep 16, 2024
Merged

fix(UI): Remove spinner and client side ad container elements when calling destroy #7320

merged 1 commit into from
Sep 16, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented Sep 16, 2024

Fixes #7311

Original author: @absidue
@avelad avelad added type: bug Something isn't working correctly component: UI The issue involves the Shaka Player UI priority: P2 Smaller impact or easy workaround labels Sep 16, 2024
@avelad avelad added this to the v4.12 milestone Sep 16, 2024
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%
@avelad avelad merged commit 3d51cb3 into shaka-project:main Sep 16, 2024
20 of 21 checks passed
@shaka-bot shaka-bot mentioned this pull request Sep 14, 2024
Open
@avelad avelad deleted the destroy-ui branch September 16, 2024 08:35
avelad added a commit that referenced this pull request Sep 18, 2024
@avelad
fix(UI): Remove spinner and client side ad container elements when ca…
2c44f2e 
…lling destroy (#7320)

Fixes #7311

Original author: @absidue
@shaka-bot shaka-bot mentioned this pull request Sep 18, 2024
Merged
avelad added a commit that referenced this pull request Sep 18, 2024
@avelad
fix(UI): Remove spinner and client side ad container elements when ca…
192f9ad 
…lling destroy (#7320)

Fixes #7311

Original author: @absidue
@shaka-bot shaka-bot mentioned this pull request Sep 18, 2024
Merged
joeyparrish pushed a commit that referenced this pull request Sep 18, 2024
@avelad @joeyparrish
fix(UI): Remove spinner and client side ad container elements when ca…
52b48be 
…lling destroy (#7320)

Fixes #7311

Original author: @absidue
@shaka-bot shaka-bot mentioned this pull request Sep 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: UI The issue involves the Shaka Player UI priority: P2 Smaller impact or easy workaround type: bug Something isn't working correctly
3 participants
@avelad @shaka-bot @theodab