Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update base16 URLs to link to community run version #2871

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JamyGolden
Copy link

Tinted Theming (previously base16-project) is a maintained and community run version of base16: tinted-theming/home#51

A discussion around creating a base16 organization originally took place in 2016 on an issue in the original base16 repo: https://web.archive.org/web/20220603173440/https://github.com/chriskempson/base16/issues/74. The repo was subsequently nuked and most git history as well as PRs and issues were destroyed (which is why I linked the web archive version of the issue).

PR description

This PR updates the following links:

  • https://github.com/chriskempson/base16 -> https://github.com/tinted-theming/home
  • https://github.com/chriskempson/base16/blob/master/styling.md -> https://github.com/tinted-theming/home/blob/main/styling.md
  • https://github.com/chriskempson/base16-shell -> https://github.com/tinted-theming/base16-shell

Our base16-shell repo is updated weekly with the latest schemes.

@sharkdp
Copy link
Owner

sharkdp commented Feb 24, 2024

@mk12 Only if you find the time... does this look good to you?

@JamyGolden This only changes links. But the actual base16 themes in the repo are not touched?

@JamyGolden
Copy link
Author

JamyGolden commented Feb 24, 2024

@sharkdp yes that is correct, themes are not touched in this PR. The "base16" and "base16-256" theme in the bat repo allow the ansi colors, set by base16-shell, to be automatically applied to bat. This change just updates the readme links so if people discover base16 through bat they can use the maintained and community version of it.

@mk12
Copy link
Contributor

mk12 commented Feb 25, 2024

@sharkdp It doesn't make much difference as far as bat is concerned, I think @JamyGolden is basically requesting a vote in favor of their fork as the actively maintained project. From a cursory look, it seems that the chriskempson repo is not really maintained (no commits in 2 years), and he has been a poor collaborator, deleting repos without warning, not responding to contributors, blocking people. In fact I was annoyed recently that I couldn't find a base16 issue I wanted to refer to — now I realize Chris deleted it. So I'm in favor of merging this.

(Aside: I always found the whole base16 ecosystem to be way too complicated for my needs. All I care about is having a convention for CLI programs to use the 16 color palette in a way that works with both dark and light terminal themes, i.e. treat 0 and 7 as background/foreground instead of black/white. And then if you need a few more slots, you can use some from the full 256 palette. That's why base16 has a standard variant and 256 variant. Base16-shell is a hack for terminal emulators that don't let you customize the full 256 colors. I use the kitty terminal, which supports customizing all of them, so I use my own setup https://github.com/mk12/base16-kitty.)

@JamyGolden
Copy link
Author

@sharkdp I've resolved the CHANGELOG conflict, are you happy to merge this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants