Skip to content
This repository has been archived by the owner on Apr 11, 2023. It is now read-only.

White Vim Vixen Console frame always visible at bottom of GitHub pages #1424

Open
asampal opened this issue May 22, 2022 · 64 comments · May be fixed by #1437
Open

White Vim Vixen Console frame always visible at bottom of GitHub pages #1424

asampal opened this issue May 22, 2022 · 64 comments · May be fixed by #1437

Comments

@asampal
Copy link

asampal commented May 22, 2022

I'm opening this issue because:

  • I'm reporting a bug

Description

The Vim Vixen iframe with id vimvixen-console-frame is always showing, even when the extension is not being actively used, on GitHub pages. The content of the frame is empty/white.

Steps to Reproduce

-use Firefox Nightly

  • go to GitHub site
  • observe white area at the bottom of page

image

System configuration

  • Operating system: Windows 11
  • Firefox version: Nightly 102.0a1
  • Vim-Vixen version: 1.2.3
@jackysee
Copy link

Same here.
It happens to the sites that applied the CSS color-scheme: dark.

vixen-ff

@adudenamedruby
Copy link

Yep, also seeing this.

@diimdeep
Copy link

diimdeep commented Jun 1, 2022

Yup, this makes plugin unusable.

@Vis5
Copy link

Vis5 commented Jun 4, 2022

+1. I'm currently working around this issue by using Custom CSS add-on. Would love to see it fixed.

@Aiedails
Copy link

Also for Nightly 103.0a1 on Plasma 5.24.5 Archlinux 5.18.2-arch1-1

@SoundZero
Copy link

I also get the fat white bar at the bottom for many sites, but not all. I'm using FF Developer Edition 102.0b7 (64-bit). Seems the "vimvixen-console-frame" iframe is to blame...

@gi1242
Copy link

gi1242 commented Jun 28, 2022

Just FYI, Firefox 102.0 hit Arch today, and this bug is present there. It's going to affect a lot more users now...

@debnath-d
Copy link

Just FYI, Firefox 102.0 hit Arch today, and this bug is present there. It's going to affect a lot more users now...

Exactly! Came here after the update.

People familiar with web development might open the dev tools in their browser and figure out the white bar being caused by this particular add-on, but others won't even be able to figure out what's causing the issue.

@jackysee
Copy link

+1. I'm currently working around this issue by using Custom CSS add-on. Would love to see it fixed.

@Vis5 what's your work around css?

@majewsky
Copy link

This workaround CSS works for me:

.vimvixen-console-frame {
  color-scheme: light !important;
}
@AsianKoala
Copy link

Yep just got this after Firefox updated to 102.0 on the AUR.

@jackysee
Copy link

@keyb0ardninja because you still need to use the console

@debnath-d
Copy link

@keyb0ardninja because you still need to use the console

Just realized after commenting and deleted my comment before seeing yours 😅

benwaffle pushed a commit to benwaffle/vim-vixen that referenced this issue Jun 30, 2022
Sites that use `color-scheme: dark` result in Vim Vixen's iframe looking
like a white box when it's actually supposed to be hidden. This started
in Firefox 102.

Fixes ueokande#1433
Fixes ueokande#1424
Fixes ueokande#1429
@InvisibleRain
Copy link

@wraiford
Copy link

wraiford commented Jul 4, 2022

As a temporary workaround until this gets fixed, it's possible to disable Vim Vixen using the blacklist fuctionality in the extension's preferences:

"blacklist": [
    "github.com/*",
    "*.mozilla.org/*"
]
willbush added a commit to willbush/system that referenced this issue Jul 5, 2022
@pfr-dev
Copy link

pfr-dev commented Jul 5, 2022

This is not just an issue for GitHub pages, I get this on most web pages and tbh I'd rather use my mouse than disable dark mode.

@jessarcher
Copy link

jessarcher commented Jul 6, 2022

I think the issue has something to do with https://fvsch.com/transparent-iframes

If I add the following to src/console/index.html then it seems to make the iframe transparent again, however, it's briefly still white while the page is loading:

<meta name="color-scheme" content="light dark">

Edit: This seems to fix it for GitHub, but it adds a new dark box to the bottom of Twitter 😠 I still think the issue has something to do with how Firefox now handles the background color of iframes.

@pfr-dev
Copy link

pfr-dev commented Jul 6, 2022

@jessarcher Thanks for sharing that article, it would seem that is precicely the issue. As a Firefox user, and as the article suggests, I may be stuck until Firefox implements the opaque iframe logic.

@jessarcher
Copy link

@jessarcher Thanks for sharing that article, it would seem that is precicely the issue. As a Firefox user, and as the article suggests, I may be stuck until Firefox implements the opaque iframe logic.

I think the problem is that Firefox has implemented the opaque iframe logic. So now, when the website has a CSS color-scheme that doesn't match the vim-vixen iframe (currently none) it gives it an opaque background.

I think the trick might be getting the iframe to detect the color-scheme of the parent page and then setting its own color-scheme to the same value so that Firefox will use a transparent background on the iframe.

@jessarcher
Copy link

I think the trick might be getting the iframe to detect the color-scheme of the parent page and then setting its own color-scheme to the same value so that Firefox will use a transparent background on the iframe.

I have a PR with this solution at #1437. The white background was still briefly visible while the page is loading so I've also set the <iframe> height to 0px when the console is closed.

@noobaldrin
Copy link

Can anyone tell me how to install from github? This issue is really annoying.

@jman-schief
Copy link

Can anyone tell me how to install from github? This issue is really annoying.

@noobaldrin The instructions to build and install a fork of this WebExtension with this issue fixed are at this comment. There is no direct link for a ready-made package with the fix. Thanks @jessarcher for authoring #1437.

if you're not comfortable with that, as an alternative you can temporarily install another Firefox add-on and apply the workaround suggested at this comment.

@noobaldrin
Copy link

While this extension gets fixed I've been using this other extension named Tridactyl, it's very similar and it woks pretty well, I'm only sharing it if anyone wants to give it a shot

I'm really sorry to say, but after weeks of no action, this is the best way to go.

@ueokande 助けてください!

I used to use Tridactyl until firefox moved to version 4 where it started to not work.
Is it any better than vim-vixen now?

@asampal
Copy link
Author

asampal commented Aug 17, 2022

Is there a way to override some of Tridactyl's shortcuts? YouTube video control shortcuts seem to be taken over by the extension.

@liamtimms
Copy link

liamtimms commented Aug 17, 2022

I think it's best to direct more specific questions about tridactyl to https://github.com/tridactyl/tridactyl to avoid cluttering the issue tracker here. I know I personally have appreciated using vim-vixen for years and may come back if this is addressed.

@peteromero
Copy link

Is there a way to override some of Tridactyl's shortcuts? YouTube video control shortcuts seem to be taken over by the extension.

just read the manual. nice explanation.
the command you need begins with "b" and ends with "d" ;)

@InvisibleRain
Copy link

There hasn't been any response for 3 months and still no fork?

@stekern
Copy link

stekern commented Aug 22, 2022

If you have enabled loading of userChrome.css and userContent.css in Firefox, you can also fix the bug without installing any additional plugins for modifying CSS by adding the following to your userContent.css:

/* Workaround for vim-vixen issue
 * https://github.com/ueokande/vim-vixen/issues/1424
 */
.vimvixen-console-frame {
  height: 0px;
  color-scheme: light !important;
}
@victorz
Copy link

victorz commented Sep 18, 2022

What's taking so long to fix this? How can we help? This is easily the best keyboard shortcut driven navigation add-on for Firefox that I know of, and I've tried quite a few. I would love to help fix this. Point me in the right direction, please!

@hrqmonteiro
Copy link

What's taking so long to fix this? How can we help? This is easily the best keyboard shortcut driven navigation add-on for Firefox that I know of, and I've tried quite a few. I would love to help fix this. Point me in the right direction, please!

Cause the author doesn't give a f*ck about it's users.

@ajakk
Copy link

ajakk commented Sep 18, 2022

What's taking so long to fix this? How can we help? This is easily the best keyboard shortcut driven navigation add-on for Firefox that I know of, and I've tried quite a few. I would love to help fix this. Point me in the right direction, please!

Cause the author doesn't give a f*ck about it's users.

This attitude really has no place anywhere in open source. You're welcome to fix it in your own fork.

@pataquets
Copy link

What's taking so long to fix this? How can we help? This is easily the best keyboard shortcut driven navigation add-on for Firefox that I know of, and I've tried quite a few. I would love to help fix this. Point me in the right direction, please!

Cause the author doesn't give a f*ck about it's users.

This attitude really has no place anywhere in open source. You're welcome to fix it in your own fork.

Agreed. The author might be busy and has no obligation, and being rude will definitely not help.
Instead, I've switched to Tridactyl two months ago and it works wonderfully (I found it even more customizable). Thanks @AlanMejia10 for the suggestion, BTW!

@victorz
Copy link

victorz commented Sep 19, 2022

Agreed. The author might be busy and has no obligation, and being rude will definitely not help.

But is there a PR up? How can we help get the ball rolling on this?

Instead, I've switched to Tridactyl two months ago and it works wonderfully (I found it even more customizable). Thanks @AlanMejia10 for the suggestion, BTW!

I tried that. Definitely wasn't as smooth as vixen, in my opinion. 😔 I really want to fix this.

@majewsky
Copy link

But is there a PR up?

Yes, in the right sidebar under the "Development" section, you can see a link to #1437.

@zoj613
Copy link

zoj613 commented Oct 19, 2022

All this time I thought this was caused by Dark Reader since it only ever appeared when activating dark mode. I have been avoiding dark mode for months because of this and I just found this issue now it disappeared after disabling vim-vixen. Are there alternatives since this plugin does not work when on github?

@noobaldrin
Copy link

All this time I thought this was caused by Dark Reader since it only ever appeared when activating dark mode. I have been avoiding dark mode for months because of this and I just found this issue now it disappeared after disabling vim-vixen. Are there alternatives since this plugin does not work when on github?

If you're still having this issue then it's unmaintained now and it's time to move on. I'm currently using Tridactyl now. Thanks for this issue, I can now choose Tridactyl again and realize that it's much better.

@Ultra980
Copy link

Ultra980 commented Oct 22, 2022

If you have enabled loading of userChrome.css and userContent.css in Firefox, you can also fix the bug without installing any additional plugins for modifying CSS by adding the following to your userContent.css:

/* Workaround for vim-vixen issue
 * https://github.com/ueokande/vim-vixen/issues/1424
 */
.vimvixen-console-frame {
  height: 0px;
  color-scheme: light !important;
}

This doesn't work for me...

@alex27riva
Copy link

Same for me

@yujikiriki
Copy link

If you have enabled loading of userChrome.css and userContent.css in Firefox, you can also fix the bug without installing any additional plugins for modifying CSS by adding the following to your userContent.css:

/* Workaround for vim-vixen issue
 * https://github.com/ueokande/vim-vixen/issues/1424
 */
.vimvixen-console-frame {
  height: 0px;
  color-scheme: light !important;
}

This doesn't work for me...

If in Firefox, install this addon: https://addons.mozilla.org/en-US/firefox/addon/css-override/
Then create a new rule in the addon with the css snippet.
The turn on when in github.
Hope it helps.

@diimdeep
Copy link

diimdeep commented Dec 15, 2022

@yujikiriki Thanks, it worked for me with Stylus extension https://add0n.com/stylus.html

@diederikdehaas
Copy link

If you have enabled loading of userChrome.css and userContent.css in Firefox, you can also fix the bug without installing any additional plugins for modifying CSS by adding the following to your userContent.css:

/* Workaround for vim-vixen issue
 * https://github.com/ueokande/vim-vixen/issues/1424
 */
.vimvixen-console-frame {
  height: 0px;
  color-scheme: light !important;
}

This doesn't work for me...

Make sure you have set toolkit.legacyUserProfileCustomizations.stylesheets set to true in about:config

@Ultra980
Copy link

@yujikiriki thanks, it worked with Custom CSS Injector, this one has global CSS.

willbush added a commit to willbush/system that referenced this issue Dec 28, 2022
@HiImTye
Copy link

HiImTye commented Feb 10, 2023

I made a userstyle to make adding this easy.
https://userstyles.org/styles/258942/vim-vixen-workaround

@antonioyon
Copy link

I found an interesting workaround that may hold a clue for a potential solution long-term solution. If I use the Find command (/ forward slash) It shrinks the frame to the correct size. Then cancel (esc) gets out of Find mode and keeps the frame at a single line.

@m20027
Copy link

m20027 commented Mar 15, 2023

I also have this bug.
and I can do same as @antonioyon at my environment
image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet