Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data loss due to WAL async flusher #531

Closed
dangleptr opened this issue Jun 14, 2019 · 0 comments · Fixed by #729
Closed

Data loss due to WAL async flusher #531

dangleptr opened this issue Jun 14, 2019 · 0 comments · Fixed by #729
Assignees
@sherman-the-tank
Milestone
R201910_beta

Comments

@dangleptr
Copy link
Contributor

Currently, wal is only hold in cache, and it will be flushed in background thread. So data maybe lost when process crashed.

The problem is very critical. We should fix it firstly.
@dangleptr dangleptr added this to the v1_beta_release milestone Jun 14, 2019
@sherman-the-tank sherman-the-tank self-assigned this Jun 30, 2019
@sherman-the-tank sherman-the-tank mentioned this issue Aug 5, 2019
Merged
dangleptr pushed a commit that referenced this issue Aug 26, 2019
@sherman-the-tank @dangleptr
Changed the WAL to call write() on every log message (#729)
166acae 
We moved away from the memory buffered version. In this PR, every log message will be written to the system cache to prevent message loss due to the crash

fixed #531
tong-hao pushed a commit to tong-hao/nebula that referenced this issue Jun 1, 2021
@sherman-the-tank @dangleptr
Changed the WAL to call write() on every log message (vesoft-inc#729)
48bbe70 
We moved away from the memory buffered version. In this PR, every log message will be written to the system cache to prevent message loss due to the crash

fixed vesoft-inc#531
yixinglu pushed a commit to yixinglu/nebula that referenced this issue Mar 21, 2022
@nebula-bots @critical27
suppress undesired ASAN error (vesoft-inc#531)
d070e31 
* suppress undesired error

* fix unstable test case

Co-authored-by: Doodle <13706157+critical27@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@sherman-the-tank @dangleptr @jude-zhu