Add support for CSS range restrictions in CSS Grammar parser #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addition to the CSS Grammar in https://drafts.csswg.org/css-values-3/#numeric-ranges See also w3c/csswg-drafts#2921 (comment)
Une one describe() and multiple its() to get one report per assertion
tidoust
reviewed
May 9, 2019
src/lib/css-grammar-parser.js
Outdated
| @@ -37,6 +37,8 @@ const primitives = new Map([ | |||
| ["position", {url: "https://drafts.csswg.org/css-values-4/#typedef-position"}] | |||
| ]); | |||
|
|
|||
| const numericTypes = ["integer", "number", "percentage", "number-percentage", "length-percentage", "frequency-percentage", "angle-percentage", "time-percentage", "dimension", "length", "angle", "time", "frequency", "resolution"]; | |||
There was a problem hiding this comment.
What is this definition for? It does not seem to be used anywhere else in the code.
There was a problem hiding this comment.
I've now removed it - I had initially thought of throwing when range was used on a non-numeric type, but that goes too close to a validator (vs a parser).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See w3c/csswg-drafts#2921 (comment)