Implement RTCRtpEncodingParameters.scaleResolutionDownTo. #48155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spec: https://w3c.github.io/webrtc-extensions/#dom-rtcrtpencodingparameters-scaleresolutiondownto Wires up scaleResolutionDownTo[1] to JS behind RuntimeEnabled flag "RTCRtpScaleResolutionDownTo". This is implemented in third_party/webrtc where it is called `requested_resolution`. WPTs are added to test basic functionality, including getting the resolution we expect, changing it on the fly, it being orientation agnostic and throwing on invalid parameters. The tests use small resolutions like 120x60 for fast ramp up even on slow bots (sending HD tends to trigger initial frame dropping and slow BW ramp up). The following test coverage is NOT included yet, but will be added in follow up CL(s): - Simulcast tests: to be written in a separate CL for reviewability. - scaleTo maintaining aspect ratio: blocked on a WebRTC fix. [1] w3c/webrtc-extensions#221 Bug: chromium:363544347 Change-Id: If930ffd686d073d2eb239763e9ea9c1390fbcef1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5828607 Reviewed-by: Dominik Röttsches <drott@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/main@{#1355122}
wpt-pr-bot
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spec: https://w3c.github.io/webrtc-extensions/#dom-rtcrtpencodingparameters-scaleresolutiondownto
Wires up scaleResolutionDownTo[1] to JS behind RuntimeEnabled flag
"RTCRtpScaleResolutionDownTo". This is implemented in third_party/webrtc
where it is called
requested_resolution.WPTs are added to test basic functionality, including getting the
resolution we expect, changing it on the fly, it being orientation
agnostic and throwing on invalid parameters.
The tests use small resolutions like 120x60 for fast ramp up even on
slow bots (sending HD tends to trigger initial frame dropping and slow
BW ramp up).
The following test coverage is NOT included yet, but will be added in
follow up CL(s):
[1] w3c/webrtc-extensions#221
Bug: chromium:363544347
Change-Id: If930ffd686d073d2eb239763e9ea9c1390fbcef1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5828607
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1355122}