[Gecko Bug 1918670] Revert canonical order enforcement for position-try-fallbacks in WPT tests.
#48162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…T tests. `<try-tactic>` is in fact order-dependent [1]: Given inline-start & end, block-start & end: 1 & 2, a & b: 1. `flip-start`: a & 2, 1 & b 2. `flip-inline`: 2 & a, 1 & b And 1. `flip-inline`: 2 & 1, a & b 2. `flip-start`: a & 1, 2 & b Are not equal. [1]: cb15043#commitcomment-146669116 Differential Revision: https://phabricator.services.mozilla.com/D222114 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1918670 gecko-commit: bf6dffc72a3452c98966164125201d146187ca35 gecko-reviewers: firefox-style-system-reviewers, emilio
wpt-pr-bot
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<try-tactic>is in fact order-dependent 1:Given inline-start & end, block-start & end: 1 & 2, a & b:
flip-start: a & 2, 1 & bflip-inline: 2 & a, 1 & bAnd
flip-inline: 2 & 1, a & bflip-start: a & 1, 2 & bAre not equal.
Differential Revision: https://phabricator.services.mozilla.com/D222114
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1918670
gecko-commit: bf6dffc72a3452c98966164125201d146187ca35
gecko-reviewers: firefox-style-system-reviewers, emilio