Exclude deleted file from wpt lint #48178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dev-ansung
requested review from
jonathan-j-lee
and removed request for
jgraham,
foolip and
DanielRyanSmith
dev-ansung
assigned dev-ansung and jonathan-j-lee and unassigned jonathan-j-lee and foolip
jonathan-j-lee
approved these changes
Sep 14, 2024
There was a problem hiding this comment.
Two nits:
- Can you add some more background in the PR description (and the squashed commit message) about the
FedCM.idl -> fedcm.idlfalse positive? - Can you confirm that this fixes the presubmit on the imported CL? The
wpt lintinvocation is here.
|
Here is how the |
The current linter incorrectly flags capitalization changes in file names as case-insensitive duplicates. This change fixes the issue by filtering out deleted files from the git diff.
|
There are no reviewers for this pull request. Please reach out on the chat room to get help with this. Thank you! |
Bonniemarie216
approved these changes
Sep 15, 2024
Bonniemarie216
approved these changes
Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current linter incorrectly flags capitalization changes in file names as case-insensitive duplicates. This change fixes the issue by filtering out deleted files from the git diff.