Split up X25519 and X448 deriveBits tests #48195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javifernandez
force-pushed
the
split-secure-curve-derive-tests
branch
from
a0d51c0
to
80d42d6
Compare
javifernandez
force-pushed
the
split-secure-curve-derive-tests
branch
from
80d42d6
to
7e11301
Compare
javifernandez
force-pushed
the
split-secure-curve-derive-tests
branch
2 times, most recently
from
b8e53c9
to
673dd94
Compare
twiss
reviewed
Sep 18, 2024
javifernandez
force-pushed
the
split-secure-curve-derive-tests
branch
from
673dd94
to
63d920d
Compare
The Curve448 algorithm is not implemented in any of the major browsers, so it's better to define its deriveBits / deriveKey tests in a separate file to avoid unnecessary noise on the tests for the Curve25519 algorithm.
javifernandez
force-pushed
the
split-secure-curve-derive-tests
branch
from
63d920d
to
7d3104a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Curve448 algorithm is not implemented in any of the major browsers, so it's better to define its tests in a separate file to avoid unnecessary noise on the tests for the Curve25519 algorithm.