webrtc wpt: fix generateCertificates WPT, add one for rejecting SHA-1 and delete legacy tests #48200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and delete legacy tests * Fixes the two remaining WPT failures for generateCertificate. * Adds a negative test for SHA-1 for RSA certificates since SHA-1 should not be used for this anymore * clean up legacy fast/ generateCertificate tests which are superseded by the WPT ones. BUG=webrtc:364338811 Change-Id: I513434b4084a2852dde7c340c8760640f3e25cb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5863274 Reviewed-by: Henrik Boström <hbos@chromium.org> Reviewed-by: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Cr-Commit-Position: refs/heads/main@{#1355957}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5863274
branch
from
6b020ff
to
59c2b85
Compare
wpt-pr-bot
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUG=webrtc:364338811
Change-Id: I513434b4084a2852dde7c340c8760640f3e25cb3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5863274
Reviewed-by: Henrik Boström <hbos@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com>
Cr-Commit-Position: refs/heads/main@{#1355957}