Functions in testfiles.py should honor --repo-root #48210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WeizhongX
requested review from
jonathan-j-lee
and removed request for
foolip and
DanielRyanSmith
|
More changes are still needed. Mark as draft for now. |
--repo-root is a parameter for wpt lint. As wpt tooling and tests are sitting in different dictories in Chromium, files_changed should accept repo_root as an arg to be consistent.
WeizhongX
force-pushed
the
fix-root-for-lint
branch
from
3147e42
to
22c2c54
Compare
|
This change is ready for review. @jgraham @jonathan-j-lee PTAL. Thanks |
Comment on lines
+196
to
200
| def files_changed(repo_root: Text, | ||
| revish: Text, | ||
| ignore_rules: Optional[Sequence[Text]] = None, | ||
| include_uncommitted: bool = False, | ||
| include_new: bool = False |
There was a problem hiding this comment.
How about:
Suggested change
| def files_changed(repo_root: Text, | |
| revish: Text, | |
| ignore_rules: Optional[Sequence[Text]] = None, | |
| include_uncommitted: bool = False, | |
| include_new: bool = False | |
| def files_changed(revish: Text, | |
| ignore_rules: Optional[Sequence[Text]] = None, | |
| include_uncommitted: bool = False, | |
| include_new: bool = False, | |
| repo_root: Text = wpt_root, |
Then there's no need to update the run_changed_files(), run_tests_affected(), wpt/run.py, and ci/jobs.py callsites.
Also, then there's no need for the repo_root or wpt_root expression below, since the caller can just omit files_changed(repo_root=...).
| @@ -133,7 +133,10 @@ def compile_ignore_rule(rule: Text) -> Pattern[Text]: | |||
| return re.compile("^%s$" % "/".join(re_parts)) | |||
|
|
|||
|
|
|||
| def repo_files_changed(revish: Text, include_uncommitted: bool = False, include_new: bool = False) -> Set[Text]: | |||
| def repo_files_changed(wpt_root: Text, | |||
There was a problem hiding this comment.
naming nit: How about repo_root so that it doesn't shadow the global wpt_root? Conceptually, it also seems more accurate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--repo-root is a parameter for wpt lint. As wpt tooling and tests are sitting in different dictories in Chromium, files_changed should accept repo_root as an arg to be consistent.