Fix WPT for cross-partition blob URL navigation #48246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `window.open` is performed with 'noopener' a null handle is returned regardless of whether the navigation succeeded. Bug: 359245744 Change-Id: I027e218b42936bdad5c0f4272f6a613978dc79de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5871987 Reviewed-by: Andrew Williams <awillia@chromium.org> Commit-Queue: Kyra Seevers <kyraseevers@chromium.org> Reviewed-by: Kyra Seevers <kyraseevers@chromium.org> Auto-Submit: Janice Liu <janiceliu@chromium.org> Cr-Commit-Position: refs/heads/main@{#1357219}
wpt-pr-bot
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
window.openis performed with 'noopener' a null handle is returned regardless of whether the navigation succeeded.Bug: 359245744
Change-Id: I027e218b42936bdad5c0f4272f6a613978dc79de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5871987
Reviewed-by: Andrew Williams <awillia@chromium.org>
Commit-Queue: Kyra Seevers <kyraseevers@chromium.org>
Reviewed-by: Kyra Seevers <kyraseevers@chromium.org>
Auto-Submit: Janice Liu <janiceliu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1357219}