[wptrunner] Guard against no browser during TestRunnerManager cleanup
#48265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even with no browser, `stop_runner()` should still call `cleanup()` in case there are other resources to clean up. Fixes web-platform-tests#48263
wpt-pr-bot
added
infra
wptrunner
gsnedders
approved these changes
Sep 19, 2024
There was a problem hiding this comment.
Thanks for fixing this so quickly! (I hadn't actually looked to see if this was a regression from your recent changes, was mostly just filing the bug so it wasn't just in my head!)
This does, yet again, make me wish that we actually had a decent testing story for the TestRunnerManager, but with so much IPC it's kinda a pain. I'd love to spend the time to hook something up to create a fake TestRunner that sends arbitrary messages, with a fake Browser, with Hypothesis to try and ensure we maintain the properties we expect the TestRunnerManager to have. But that's a decently large amount of work, even if it's maybe worthwhile doing…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even with no browser,
stop_runner()should still callcleanup()in case there are other resources to clean up.Fixes #48263