-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[css3-images] Parsing tests for images properties #9339
[css3-images] Parsing tests for images properties #9339
Conversation
cd66c37
to
0809c49
Compare
Build PASSEDStarted: 2018-02-01 15:02:00 View more information about this build on: |
Status at the end of January 2018: Edge does not support the image-rendering property. Other browsers reject some/all of the following keywords: smooth, high-quality, crisp-edges, pixelated. Only Firefox support image-orientation. Edge converts all object-position values containing keywords to percentages when serializing. Other browsers preserve keywords like 'top' and 'center'. No browsers yet reject 3-value object-position values. They are deprecated in Blink with support to be removed in M68, July 2018. For object-fit, no browsers support scale-down in combination with contain or cover. No browsers support image-resolution.
404b2c3
to
92f129c
Compare
Note that there is no consistency in how browsers are serializing
|
Note that Firefox serializes position in It'd be sweet to remove that code and make it consistent with the rest. |
That points to https://drafts.csswg.org/css-shapes/#basic-shape-serialization in particular... But I think for sanity we should just serialize the same, and |
I would like to merge at minimum the For -valid serialization of object position, I excluded the Edge serializations |
@emilio please review. The preferred serialization of has been split out into w3c/csswg-drafts#2301 and w3c/csswg-drafts#2274 . The tests can be made stricter when they are resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, given csswg-drafts issues exist to keep track of differences in serialization
Status at the end of January 2018:
Edge does not support the image-rendering property. Other browsers
reject some/all of the following keywords:
smooth, high-quality, crisp-edges, pixelated.
Only Firefox support image-orientation.
Edge converts all object-position values containing keywords to
percentages when serializing. Other browsers preserve keywords
like 'top' and 'center'.
No browsers yet reject 3-value object-position values. They are
deprecated in Blink with support to be removed in M68, July 2018.
For object-fit, no browsers support scale-down in combination with
contain or cover.
No browsers support image-resolution.