get rid of csp-module and implement secure-renderer #171
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hello @jissereitsma
you used your CSP module to implement the nonce for inline-js.
But as already discussed yireo/Yireo_CspWhitelistInlineJs#1 the module is great, but it is only a temporary solution for production.
Each extension developer should implement the secure-renderer to use inline-scripts. also Yireo :)
And then we do not need the separate extension. I don't think it is a good idea to implement the separate extension in all shops automatically, because some shops won't have the extension.
So i hope you understand me, and will approve the PR :)
Thank you!