Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typing for IonImageryProvider.fromAssetId is incorrect #11624

Closed
angrycat9000 opened this issue Nov 13, 2023 · 0 comments · Fixed by #11626
Closed

Typing for IonImageryProvider.fromAssetId is incorrect #11624

angrycat9000 opened this issue Nov 13, 2023 · 0 comments · Fixed by #11626
Labels
category - typescript

Comments

@angrycat9000
Copy link
Contributor

options is marked as required but is actually optional.

Docs do not indicate optional

cesium/packages/engine/Source/Scene/IonImageryProvider.js

Line 254 in 003922b

* @param {IonImageryProvider.ConstructorOptions} options Object describing initialization options.

default value set in the function however

cesium/packages/engine/Source/Scene/IonImageryProvider.js

Line 269 in 003922b

options = defaultValue(options, defaultValue.EMPTY_OBJECT);

This causes Typescript to indicate an error if options is not provided

image
angrycat9000 added a commit that referenced this issue Nov 13, 2023
@angrycat9000
Update JSDoc for optional options
50b6241 
Fixes #11623 and fixes #11624
@angrycat9000 angrycat9000 mentioned this issue Nov 13, 2023
Merged
pupitetris pushed a commit to pupitetris/cesium-webxr that referenced this issue Mar 4, 2024
@angrycat9000 @pupitetris
Update JSDoc for optional options
e2b5da2 
Fixes CesiumGS#11623 and fixes CesiumGS#11624
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category - typescript
1 participant
@angrycat9000