Update JSDoc for optional options #11626
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
IonImageryProvider.fromAssetId
andCesium3DTileset.fromIonAssetId
to have optional options. In both cases options arguments were not marked as optional in JSDoc causing them to be required in Typescript.Fixes #11623 and fixes #11624
Test Plan
Run
npm build-ts
Open the generated typescript definition file, and verify that both methods now include
optinons?:
instead ofoptions:
to mark them as optional